Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-wildcard-imports): use local name when changing imports #234

Merged
merged 10 commits into from
Sep 24, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Sep 19, 2024

Small update to our wildcard import rules so that imports that are renamed keep the same local name in the file. This makes it easier for us to codemod 😅

-import {ItemProps} from '@primer/react/lib-esm/deprecated/ActionList';
+import {ActionListItemProps as ItemProps} from '@primer/react/deprecated';

Edit: this also updates some of the imports to hooks that I had incorrectly implemented

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: 7ae048b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack joshblack marked this pull request as ready for review September 19, 2024 22:21
@joshblack joshblack requested a review from a team as a code owner September 19, 2024 22:21
@joshblack joshblack enabled auto-merge (squash) September 24, 2024 19:54
@joshblack joshblack merged commit 9a58afb into main Sep 24, 2024
7 checks passed
@joshblack joshblack deleted the fix/use-local-name-for-changes branch September 24, 2024 19:55
@primer-css primer-css mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants