Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add no-wildcard-imports rule #225

Merged
merged 8 commits into from
Sep 12, 2024
Merged

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Sep 9, 2024

Add support for the No Wildcard Imports rule. This rule will warn against imports from @primer/react/lib-esm and will attempt to autofix them if the path is known 👀

Note: this is not added to the recommended set of rules and instead will be enabled manually on target repos.

Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: 09589a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack joshblack marked this pull request as ready for review September 10, 2024 16:04
@joshblack joshblack requested a review from a team as a code owner September 10, 2024 16:04
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going by the tests, this looks really solid!

Note: this is not added to the recommended set of rules and instead will be enabled manually on target repos.

Good call!

@joshblack joshblack enabled auto-merge (squash) September 12, 2024 14:52
@joshblack joshblack merged commit b4698df into main Sep 12, 2024
7 checks passed
@joshblack joshblack deleted the feat/remove-wildcard-exports branch September 12, 2024 14:52
@primer-css primer-css mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants