Skip to content

Commit

Permalink
Fix Stack system prop (#212)
Browse files Browse the repository at this point in the history
* add rule

* Create nervous-coats-cross.md

* Update .changeset/nervous-coats-cross.md

---------

Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
  • Loading branch information
langermank and siddharthkp authored Aug 29, 2024
1 parent 3f92cd4 commit 78d4600
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/nervous-coats-cross.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-primer-react": patch
---

no-system-props: Add `padding` and `gap` as exceptions for `Stack`
1 change: 1 addition & 0 deletions src/rules/no-system-props.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ const excludedComponentProps = new Map([
['ProgressBar', new Set(['bg'])],
['PointerBox', new Set(['bg'])],
['Truncate', new Set(['maxWidth'])],
['Stack', new Set(['padding', 'gap'])],
])

const alwaysExcludedProps = new Set(['variant', 'size'])
Expand Down

0 comments on commit 78d4600

Please sign in to comment.