feat: add SegmentedControl.Button to no-sx-prop rule

primer · Sep 17, 2024 · 21102b7 · 21102b7
1 parent db903cd
commit 21102b7
Showing 1 changed file with 36 additions and 8 deletions.
diff --git a/src/rules/no-sx-prop.js b/src/rules/no-sx-prop.js
@@ -3,14 +3,32 @@
 const url = require('../url')
 
 const forbidden = new Set([
-  'SegmentedControl',
   // 'ActionList',
   // 'ActionList.Divider',
   // 'ActionList.Group',
   // 'ActionList.Item',
   // 'ActionList.LeadingVisual',
   // 'ActionList.LinkItem',
 
+  // 'ActionMenu.Button',
+  // 'ActionMenu.Overlay',
+
+  // 'Avatar',
+  // 'AvatarStack',
+
+  // 'BorderBox',
+  // 'Box',
+
+  // 'BranchName',
+
+  // 'Breadcrumbs',
+  // 'Breadcrumbs.Item',
+
+  'SegmentedControl',
+  'SegmentedControl.Button',
+
+  'SplitPageLayout.Pane',
+
   // 'UnderlineNav',
   // 'UnderlineNav.Item',
 ])
@@ -36,14 +54,24 @@ module.exports = {
   create(context) {
     return {
       JSXOpeningElement(node) {
-        if (!forbidden.has(node.name.name)) {
-          return
+        if (node.name.type === 'JSXMemberExpression') {
+          if (node.name.object.type === 'JSXIdentifier' && node.name.property.type === 'JSXIdentifier') {
+            const name = `${node.name.object.name}.${node.name.property.name}`
+            if (forbidden.has(name)) {
+              context.report({
+                node,
+                messageId: 'sxProp',
+              })
+            }
+          }
+        } else if (node.name.type === 'JSXIdentifier') {
+          if (forbidden.has(node.name.name)) {
+            context.report({
+              node,
+              messageId: 'sxProp',
+            })
+          }
         }
-
-        context.report({
-          node,
-          messageId: 'sxProp',
-        })
       },
     }
   },