update default for flex wrap styles #2388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
flex-wrap: no-wrap
What approach did you choose and why?
no-wrap
is the default value.d-flex
in https://github.com/primer/css, but looking at how the CSS is applied in the browser it doesn't look like Primer setswrap
on that class either, so it wouldn't be the default for an application using Primer (although our application may be behind in Primer versions)What should reviewers focus on?
flex-nowrap
line be first in the list in the documentation, as the default?Can these changes ship as is?