Skip to content

feat: add label slot to Button component #8306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Benjaming61001 wants to merge 1 commit into
base: master
Choose a base branch
from
+30 −1
Open

feat: add label slot to Button component #8306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions apps/showcase/doc/common/apidoc/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8816,6 +8816,19 @@
"returnType": "VNode<RendererNode, RendererElement, Object>[]",
"description": "Custom icon template."
},
{
"name": "label",
"parameters": [
{
"name": "scope",
"optional": false,
"type": "{\n \t <span class=\"ml-3 doc-option-parameter-name\">class</span>: <span class=\"doc-option-parameter-type\">string</span>, <span class=\"doc-option-parameter-type\">// Style class of the label.</span>\n }",
"description": "label slot's params."
}
],
"returnType": "VNode<RendererNode, RendererElement, Object>[]",
"description": "Custom label template."
},
{
"name": "loadingicon",
"parameters": [
Expand Down
4 changes: 4 additions & 0 deletions packages/primevue/scripts/components/button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ const ButtonSlots = [
name: 'icon',
description: 'Custom icon template.'
},
{
name: 'label',
description: 'Custom label template.'
},
{
name: 'loadingicon',
description: 'Custom loading icon template.'
Expand Down
10 changes: 10 additions & 0 deletions packages/primevue/src/button/Button.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,16 @@ export interface ButtonSlots {
*/
class: string;
}): VNode[];
/**
* Custom label template.
* @param {Object} scope - label slot's params.
*/
label(scope: {
/**
* Style class of the label.
*/
class: string;
}): VNode[];
/**
* Custom loading icon template.
* @param {Object} scope - loading icon slot's params.
Expand Down
4 changes: 3 additions & 1 deletion packages/primevue/src/button/Button.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
<slot v-else name="icon" :class="[cx('icon')]" v-bind="ptm('icon')">
<span v-if="icon" :class="[cx('icon'), icon, iconClass]" :data-p="dataIconP" v-bind="ptm('icon')"></span>
</slot>
<span v-if="label" :class="cx('label')" v-bind="ptm('label')" :data-p="dataLabelP">{{ label }}</span>
<slot name="label" :class="cx('label')" v-bind="ptm('label')">
<span v-if="label" :class="cx('label')" v-bind="ptm('label')" :data-p="dataLabelP">{{ label }}</span>
</slot>
<Badge v-if="badge" :value="badge" :class="badgeClass" :severity="badgeSeverity" :unstyled="unstyled" :pt="ptm('pcBadge')"></Badge>
</slot>
</component>
Expand Down
Loading