Skip to content

mod examples README #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ihatov08
Copy link

@ihatov08 ihatov08 commented Jun 13, 2025

Thank you for creating a great library.

I tried running the examples locally as described in the README, but they didn't work.

This pull request updates the setup instructions for two example projects in the craft.js repository to improve consistency and clarity. The changes replace npm commands with yarn commands and add missing setup instructions for the landing page example.

Updates to setup instructions:

  • examples/basic/README.md: Updated the setup commands to use yarn instead of npm. The new instructions include yarn install, yarn build, and yarn workspace example-basic start for running the basic example.
  • examples/landing/README.md: Added a "Try it out" section with setup instructions for the landing page example, using yarn commands (yarn install, yarn build, and yarn workspace example-landing start).

@ihatov08 ihatov08 requested a review from prevwong as a code owner June 13, 2025 02:15
Copy link

vercel bot commented Jun 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
craftjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2025 2:18am

Copy link

changeset-bot bot commented Jun 13, 2025

⚠️ No Changeset found

Latest commit: 7958f80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant