Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions.delete isn't deleting all nodes within a canvas #64

Closed
jmschneider opened this issue Apr 17, 2020 · 0 comments
Closed

actions.delete isn't deleting all nodes within a canvas #64

jmschneider opened this issue Apr 17, 2020 · 0 comments

Comments

@jmschneider
Copy link
Contributor

Describe the bug
When I call actions.delete on a canvas, it is not deleting all of the nodes under that canvas. It appears to be deleting some but not all. The nodes disappear from the interface but still exists in the editor state.

To Reproduce
Steps to reproduce the behavior:

  1. Create a canvas with multiple nodes
  2. Call actions.delete(canvas_id)
  3. Call query.serialize()
  4. You should still see the deleted nodes in the serialized state

Expected behavior
Based on these lines, I think it is supposed to be deleting all the nodes within the canvas.

Your environment

Software Version(s)
craft.js 0.1.0-beta.5
React 16.13.1
TypeScript 3.8.3
Browser Firefox
npm/Yarn yarn
Operating System OS X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant