Skip to content

Commit 3f5b46f

Browse files
authored
✨ Add SlevomatCodingStandard.Functions.RequireTrailingCommaInCall (#6)
1 parent 4eb5068 commit 3f5b46f

File tree

4 files changed

+46
-0
lines changed

4 files changed

+46
-0
lines changed

PreviousNextDrupal/ruleset.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
</rule>
2626

2727
<!-- SlevomatCodingStandard.Functions -->
28+
<rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInCall" />
2829
<rule ref="SlevomatCodingStandard.Functions.UnusedInheritedVariablePassedToClosure" />
2930

3031
<!-- Drupal -->
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
<?php
2+
3+
declare(strict_types = 1);
4+
5+
namespace PreviousNext\CodingStandard\Tests\Sniffs;
6+
7+
use SlevomatCodingStandard\Sniffs\Functions\RequireTrailingCommaInDeclarationSniff;
8+
9+
/**
10+
* @covers \SlevomatCodingStandard\Sniffs\Functions\RequireTrailingCommaInDeclarationSniff
11+
*/
12+
final class RequireTrailingCommaInCallTest extends Base {
13+
14+
public function testNoError(): void {
15+
$report = self::checkFile(__DIR__ . '/fixtures/RequireTrailingCommaInCallNoError.php');
16+
self::assertNoSniffErrorInFile($report);
17+
}
18+
19+
public function testError(): void {
20+
$report = self::checkFile(__DIR__ . '/fixtures/RequireTrailingCommaInCallError.php');
21+
self::assertSame(1, $report->getErrorCount());
22+
self::assertSniffError($report, 7, sniffName: 'SlevomatCodingStandard.Functions.RequireTrailingCommaInCall', code: RequireTrailingCommaInDeclarationSniff::CODE_MISSING_TRAILING_COMMA);
23+
}
24+
25+
protected static function getSniffName(): string {
26+
return 'SlevomatCodingStandard.Functions.RequireTrailingCommaInCall';
27+
}
28+
29+
}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?php
2+
3+
declare(strict_types = 1);
4+
5+
hello(
6+
'foo',
7+
'bar'
8+
);
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?php
2+
3+
declare(strict_types = 1);
4+
5+
hello(
6+
'foo',
7+
'bar',
8+
);

0 commit comments

Comments
 (0)