Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] feat: expose reporter api #40

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] feat: expose reporter api #40

wants to merge 1 commit into from

Conversation

ikatyang
Copy link
Member

demo #39

@ikatyang ikatyang mentioned this pull request Jul 31, 2017
Closed
@zertosh
Copy link
Member

zertosh commented Aug 1, 2017

I like the idea, but it seems like you're pulling out stuff into "utils" for the sake of pulling them out.

@ikatyang
Copy link
Member Author

ikatyang commented Aug 1, 2017 •
edited
Loading

This PR is just for demo, since the exposed API should be in another package due to peerDeps. 😅

@ikatyang ikatyang closed this Aug 1, 2017
@ikatyang ikatyang deleted the expose-reporter-api branch August 1, 2017 00:10
@not-an-aardvark
Copy link
Member

We could always remove the eslint peerDependency if we're exposing an API that works without eslint.

@ikatyang
Copy link
Member Author

ikatyang commented Aug 1, 2017

OK, I'll reopen and modify this PR later.

@ikatyang ikatyang restored the expose-reporter-api branch August 1, 2017 00:42
@ikatyang
Copy link
Member Author

ikatyang commented Aug 1, 2017

I somehow can't reopen this PR, so I create a new one #41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikatyang @zertosh @not-an-aardvark