[native] Disable IPAddress type on presto native #23436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsaka
requested review from
a team,
jaystarshot,
feilong-liu and
ClarenceThreepwood
as code owners
feilong-liu
reviewed
Aug 14, 2024
presto-main/src/main/java/com/facebook/presto/sql/planner/sanity/CheckNoIPAddressType.java
Outdated
Show resolved
Hide resolved
mohsaka
force-pushed
the
disable_ipaddress_native
branch
from
7cb8f00
to
d0d9e30
Compare
feilong-liu
reviewed
Aug 16, 2024
...n/src/main/java/com/facebook/presto/sql/planner/sanity/CheckUnsupportedPrestissimoTypes.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/com/facebook/presto/sql/planner/sanity/CheckUnsupportedPrestissimoTypes.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/com/facebook/presto/sql/planner/sanity/CheckUnsupportedPrestissimoTypes.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/com/facebook/presto/sql/planner/sanity/CheckUnsupportedPrestissimoTypes.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/com/facebook/presto/sql/planner/sanity/CheckUnsupportedPrestissimoTypes.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/com/facebook/presto/sql/planner/sanity/CheckUnsupportedPrestissimoTypes.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/sql/planner/sanity/TestCheckNoIPAddressType.java
Outdated
Show resolved
Hide resolved
|
@feilong-liu Really appreciate the thorough review! Pretty sure I got everything fixed up. Please let me know if there were any misunderstandings or other comments. Thanks! |
amitkdutta
changed the title
feilong-liu
reviewed
Aug 19, 2024
...n/src/main/java/com/facebook/presto/sql/planner/sanity/CheckUnsupportedPrestissimoTypes.java
Outdated
Show resolved
Hide resolved
feilong-liu
approved these changes
Aug 19, 2024
mohsaka
force-pushed
the
disable_ipaddress_native
branch
from
77fdd09
to
d5d4784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have merged in support for IPADDRESS type in velox, however the order by is not supported due to
facebookincubator/velox#10338
As a result, we will block IPAddress type on presto native similar to how timezone with timestamp is disabled via
#23200
Motivation and Context
We do not want correctness failures since IPAddress type has been added.
More context:
facebookincubator/velox#10596 (comment)
Impact
Test Plan
Followed the tests from the Timestamp with timezone disabling.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: