Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccumulatorState cannot have other methods #16678

Open
kaikalur opened this issue Sep 2, 2021 · 0 comments
Open

AccumulatorState cannot have other methods #16678

kaikalur opened this issue Sep 2, 2021 · 0 comments
Labels

Comments

@kaikalur
Copy link
Contributor

kaikalur commented Sep 2, 2021

Currently, AccumulatorState has exactly one method getEstimatedSize. And this is codegen'd in the accumulator compiler which just hard codes that one method and tries to produce class with state for other get/is/set functions like Java beans. This is too subtle and brittle. We should have add an annotation or something in case there is a need for non-serializable parts in the AccumulatorState

@kaikalur kaikalur added the Core label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant