fix(docs): cleanup minor typo in useFirestoreConnect.md #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #949 +/- ##
=======================================
Coverage 88.33% 88.33%
=======================================
Files 29 29
Lines 797 797
=======================================
Hits 704 704
Misses 93 93 |
identical typo fix
prescottprue
changed the title
|
Population is supported in Firestore, but just not the full profile population Agreed that it should be done, I think #915 is for updating the docs |
prescottprue
added a commit
that referenced
this pull request
May 31, 2020
* fix(types): fix file blob type for uploadFile and uploadFiles (#950) - @rscotten * chore(docs): cleanup minor typo in useFirestoreConnect.md (#949) - @gregfenton * chore(tests): fix typo "merge" to "merges" in reducer test file (#948) - @yukimurasawa * chore(docs): remove note about populate not being supported in firestore (#915) * chore(examples): clarify explanation in `watchEvent` example snippet (#910) * chore(docs): add correct syntax highlighting to example in firestore.md * chore(build): improve lint command * chore(build): only require jsdoc comments in source Co-authored-by: Richard Scotten <rscotten@users.noreply.github.com> Co-authored-by: gregfenton <greg.fenton@gmail.com> Co-authored-by: yukimurasawa <yuki.murasawa0826@gmail.com> Co-authored-by: yukimurasawa <yuki.murasawa.0826@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QUESTION: this page still indicates that "populate is not supported". Is this still the case for firestore?
Description
Check List
If not relevant to pull request, check off as complete
Relevant Issues