Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): fix typo "merge" to "merges" in reducer test file #948

Merged

Conversation

yukimurasawa
Copy link
Contributor

@yukimurasawa yukimurasawa commented May 30, 2020

Description

I made tiny change in test/unit/reducer.spec.js
I unified to "merges"

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #948 into master will not change coverage.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##           master     #948   +/-   ##
=======================================
  Coverage   88.33%   88.33%           
=======================================
  Files          29       29           
  Lines         797      797           
=======================================
  Hits          704      704           
  Misses         93       93           

@prescottprue prescottprue changed the title Fix typo in test file chore(tests): fix typo "merge" to "merges" in reducer test file May 31, 2020
@prescottprue prescottprue changed the base branch from master to v3.5.1 May 31, 2020 20:48
@prescottprue prescottprue merged commit 2701c70 into prescottprue:v3.5.1 May 31, 2020
@prescottprue prescottprue mentioned this pull request May 31, 2020
3 tasks
prescottprue added a commit that referenced this pull request May 31, 2020
* fix(types): fix file blob type for uploadFile and uploadFiles (#950) - @rscotten
* chore(docs): cleanup minor typo in useFirestoreConnect.md (#949) - @gregfenton
* chore(tests): fix typo "merge" to "merges" in reducer test file (#948) - @yukimurasawa
* chore(docs): remove note about populate not being supported in firestore (#915)
* chore(examples): clarify explanation in `watchEvent` example snippet (#910)
* chore(docs): add correct syntax highlighting to example in firestore.md
* chore(build): improve lint command
* chore(build): only require jsdoc comments in source

Co-authored-by: Richard Scotten <rscotten@users.noreply.github.com>
Co-authored-by: gregfenton <greg.fenton@gmail.com>
Co-authored-by: yukimurasawa <yuki.murasawa0826@gmail.com>
Co-authored-by: yukimurasawa <yuki.murasawa.0826@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants