Skip to content

fix(profile): prevent cannot read property '_getservice' of undefined error #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

Zubnix
Copy link

@Zubnix Zubnix commented Dec 10, 2019

This fixes a bug where calling

firebase = useFirebase()
firebase.updateProfile(..)

would result in a:

TypeError: Cannot read property '_getService' of undefined

insides firebase because the 'this' keyword would be undefined, caused by the destructured database function.

 context, resulting in `cannot read property '_getservice' of
  undefined`.
@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #801 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #801   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files          29       29           
  Lines         759      759           
=======================================
  Hits          694      694           
  Misses         65       65

@prescottprue prescottprue changed the title Fix bug cannot read property '_getservice' of undefined. fix(profile): prevent cannot read property '_getservice' of undefined error Dec 11, 2019
@prescottprue prescottprue changed the base branch from master to v3.0.6 December 11, 2019 00:49
@prescottprue prescottprue merged commit bca2a49 into prescottprue:v3.0.6 Dec 11, 2019
@prescottprue prescottprue mentioned this pull request Dec 11, 2019
3 tasks
prescottprue added a commit that referenced this pull request Dec 22, 2019
* fix(profile): prevent `cannot read property '_getservice' of undefined` error - #801 - @Zubnix
* fix(types): fix arguments in `resetPassword` - #803 - @magrinj
* fix(docs): documentation about `resetPassword` - #803 - @magrinj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants