Firebase.login doesn't return an object in some cases

[Shahor]

Do you want to request a feature or report a bug?

Reporting a bug

What is the current behavior?

c.f. this gist the firebase.login method just returns the user uid when logging in instead of an object as stated in the documentation.

What is the expected behavior?

The login method should return an object as stated by the documentation.

Which versions of dependencies, and which browser and OS are affected by this issue? Did this work in previous versions or setups?

    "firebase": "^4.0.0",
    "react": "^15.6.1",
    "react-dom": "^15.6.1",
    "react-redux": "^5.0.5",
    "react-redux-firebase": "^1.4.4",
    "react-router-dom": "^4.1.1",
    "redux": "^3.7.2",
    "redux-thunk": "^2.2.0",

[prescottprue]

Released in v1.5.0-rc.4.

[marekolszewski]

@prescottprue The fix for this is nice, but it doesn't include the profile object as is included is social logins. Should it be?

Also, it appears that the bug still exists in v2.

[marekolszewski]

@prescottprue Perhaps more importantly, the user object is inside the 'user' field in the social case, so perhaps the fix should return { user: userData } instead.

[prescottprue]

@marekolszewski You are correct that the signature should be the same (i.e. using user parameter).

login does not create a profile by default if you are using email login (since there is email is the only data with which to do it), and that is the function that loads profile that is returned.

Should be easy enough to just load the profile and pass it back if using calling login with an email, but we will have to keep it configurable. Most will not want to unnecessarily load profile since it is more common to get profile through state instead of in the login method response.

The fix for login is going to be in the next upcoming v2 release.