Skip to content

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Oct 17, 2025

No description provided.

Copy link

codspeed-hq bot commented Oct 17, 2025

CodSpeed Performance Report

Merging #91 will degrade performances by 17.79%

Comparing new_release (58bb66e) with main (cdb7094)

Summary

⚡ 9 improvements
❌ 3 regressions
✅ 666 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_m4_with_x[True-float32-1,000-1,000,000] 3.8 ms 3.4 ms +13.15%
test_m4_with_x[True-int32-1,000-1,000,000] 3.5 ms 3.9 ms -10.51%
test_m4_with_x[True-int64-5,000-100,000] 4.8 ms 4.2 ms +13.15%
test_minmax_with_x[True-float64-1,000-100,000] 2.2 ms 1.7 ms +29.65%
test_minmax_with_x[True-int32-1,000-100,000] 2.1 ms 1.6 ms +30.13%
test_nanm4_with_x[True-int32-1,000-1,000,000] 3.9 ms 3.5 ms +12.42%
test_nanminmax_with_x[True-float32-1,000-1,000,000] 3.6 ms 4 ms -11.26%
test_nanminmax_with_x[True-float32-1,000-100,000] 2 ms 1.5 ms +29.27%
test_nanminmax_with_x[True-float64-1,000-100,000] 1.7 ms 2.1 ms -17.79%
test_nanminmax_with_x[True-int32-1,000-100,000] 2 ms 1.6 ms +23.95%
test_nanminmaxlttb_with_x[True-float32-1,000-100,000] 4.9 ms 4.1 ms +20.1%
test_nanminmaxlttb_with_x[True-float32-100-1,000,000] 3.5 ms 3.1 ms +14.38%

@my1e5
Copy link
Contributor

my1e5 commented Oct 20, 2025

Hey @jvdd, thanks for working on this PR. I notice that the Windows builds are failing with

💥 maturin failed
  Caused by: Interpreters ["CPython 3.8", "CPython 3.9", "CPython 3.10", "CPython 3.11", "CPython 3.12", "CPython 3.14"] 
  were found in maturin's bundled sysconfig, but compiling for Windows without an interpreter requires 
  PyO3's `generate-import-lib` feature

I tried adding the generate-import-lib feature to the pyo3 dependency - see my forked PR (my1e5#3) - and that seems to fix it 😄

[dependencies]
downsample_rs = { path = "downsample_rs", features = ["half"]}
-pyo3 = { version = "0.26", features = ["extension-module"] }
+pyo3 = { version = "0.26", features = ["extension-module", "generate-import-lib"] }
numpy = { version = "0.26", features = ["half"] }
half = { version = "2.6", default-features = false }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants