🔥 delegate nan behavior to aggregators #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
+ Coverage 96.42% 96.49% +0.07%
==========================================
Files 14 14
Lines 1146 1141 -5
==========================================
- Hits 1105 1101 -4
+ Misses 41 40 -1 ☔ View full report in Codecov by Sentry. |
|
Ready for review @jvdd! |
jvdd
reviewed
Feb 14, 2024
| ) | ||
|
|
||
| # TODO -> integrate NANM4 (after the candlestick PR) |
jvdd
approved these changes
Feb 14, 2024
jvdd
approved these changes
Mar 1, 2024
This was referenced Mar 11, 2024
|
I added the issue, so this can be merged @jvdd? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
check_nansargument of the FigureResampler constructor and itsadd_tracesmethod. This argument was used to check for NaNs in the input data, but this is now handled by thenan_policyargument of specific aggregators (see for instance the constructor of theMinMaxandMinMaxLTTBaggregator).