Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔍 adding init kwargs to show dash - fix for #265 #269

Merged
merged 10 commits into from
Nov 24, 2023
Merged

Conversation

jonasvdd
Copy link
Member

@jonasvdd jonasvdd commented Nov 8, 2023

Fixes #265,

This PR largely alleviates the unclarity of the show_dash_kwargs by removing these from the FigureResampler its constructor and replacing these by the kwargs of the show_dash method.

This show_dash method now also contains init_dash_kwargs which should aid in specifying Dash constructor arguments, which can be of value for kubernetes (k8s) jupyterhub notebook instances.


  • text show_dash_kwargs in register_plotly_resampler

@jonasvdd jonasvdd marked this pull request as draft November 8, 2023 09:12
jonasvdd and others added 5 commits November 8, 2023 21:56
These can be of special interest for the register_plotly_resampler method
These can be of special interest for the register_plotly_resampler method
@jvdd jvdd marked this pull request as ready for review November 22, 2023 18:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (741da5d) 96.46% compared to head (19ca5b8) 96.46%.

Files Patch % Lines
...tly_resampler/figure_resampler/figure_resampler.py 60.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files          14       14           
  Lines        1130     1130           
=======================================
  Hits         1090     1090           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonasvdd
Copy link
Member Author

Will review it tonight

@jvdd
Copy link
Member

jvdd commented Nov 23, 2023

The show_dash_kwargs are already tested for register_plotly_resampler!

default_n_shown_samples=50, show_dash_kwargs=dict(mode="inline", port=8051)

@jonasvdd jonasvdd merged commit 9b48723 into main Nov 24, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] FigureResampler show_dash in JupyterLab fails to display plot
3 participants