-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔍 adding init kwargs to show dash - fix for #265 #269
Conversation
These can be of special interest for the register_plotly_resampler method
These can be of special interest for the register_plotly_resampler method
…-resampler into bug/fix_dash_kwargs
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 14 14
Lines 1130 1130
=======================================
Hits 1090 1090
Misses 40 40 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Will review it tonight |
The plotly-resampler/tests/test_registering.py Line 132 in 741da5d
|
Fixes #265,
This PR largely alleviates the unclarity of the
show_dash_kwargs
by removing these from theFigureResampler
its constructor and replacing these by thekwargs
of theshow_dash
method.This
show_dash
method now also containsinit_dash_kwargs
which should aid in specifyingDash
constructor arguments, which can be of value for kubernetes (k8s) jupyterhub notebook instances.