-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📦 improve docs #104
📦 improve docs #104
Conversation
Codecov Report
@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 97.63% 96.93% -0.71%
==========================================
Files 10 12 +2
Lines 804 848 +44
==========================================
+ Hits 785 822 +37
- Misses 19 26 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Ready for review @jvdd! |
I looked through the examples in this MR and ran them on my system and I think this is a huge improvement:
I did not look at the remaining examples, they seemed much more advanced to me. Great job at improving the examples! I'll go ahead and try to implement this in my app now again. |
Hi @SirVer, I cannot seem to reproduce your experienced issues; could you share a pip freeze; so my python environment is an exact copy of yours? |
Thanks @SirVer! I was able to reproduce the error. 🥲 I think that the serialization support was not yet integrated into If I execute |
@jvdd; ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very nice work, quality of docs is improved significantly 🚀
This PR aims at improving the documentation of this package, as we have had several issues about the lacking documentation (#99, #91, #102)
Readme.md
Contributing.md
Changelog.md
Other stuff this PR does;
incorporate Plotly-resampler's LTTBc bindings
TODO:
EfficientLTTB
method whenLTTB_core_c
is not availablenote: this method is tested for equality with the lttbc method