Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hard-failing on unknown imp.ext values #3735

Open
bretg opened this issue Jun 6, 2024 · 6 comments
Open

Stop hard-failing on unknown imp.ext values #3735

bretg opened this issue Jun 6, 2024 · 6 comments
Labels

Comments

@bretg
Copy link
Contributor

bretg commented Jun 6, 2024

One of the RTD modules starting putting data on imp.ext, and PBS is choking on it.

This isn't right... imp.ext should be for everyone to use... PBS shouldn't assume that every value in that ext must be a bidder to the point where it hardfails.

Instead, if an unknown value in imp.ext is found, PBS should do the following:

  1. If imp.ext.prebid.bidder exists, then do nothing. The requestor has moved to the new syntax where bidders are in imp.ext.prebid and there's no need to check imp.ext anymore. Let it through.
  2. If imp.ext.prebid.bidder doesn't exist, then it's ok to warn about unknown values, but the request should otherwise proceed.

Note: we already make exceptions for many imp.ext values: ae, all, context, data, general, gpid, prebid, skadn, and tid. We can keep these special cases to reduce the number of warnings emitted.

Test cases:

  1. Add imp.ext.foo and imp.ext.prebid.bidder.appnexus to the request. There should be no warnings. imp.ext.foo should be passed to bidders.
  2. Add imp.ext.foo and imp.ext.appnexus to the request. There should be a warning about an unknown bidder "foo". imp.ext.foo should be passed to bidders.
  3. Add imp.ext.gpid and imp.ext.appnexus to the request. There should be no warnings. imp.ext.gpid should be passed to bidders.
@Slind14
Copy link

Slind14 commented Jun 6, 2024

One option might be adding it to the list of reserved keys but that is an inclusive list:

BidderReservedAll BidderName = "all" // Reserved for the /info/bidders/all endpoint.

@bretg
Copy link
Contributor Author

bretg commented Jun 6, 2024

adding it to the list of reserved keys

I suppose that would be faster, but I'd like to fix this once and for all

@bretg
Copy link
Contributor Author

bretg commented Jul 19, 2024

This is a high priority because imp.ext.igs is now a thing.

@vraybaud
Copy link
Contributor

Hey, gentle bump
Please do we have any update about this issue ?
We want to use Fledge with PBS but it looks like it's not possible with latest version of paapi PBJS module because of imp.ext.ae being replaced by imp.ext.igs.ae.

@bretg
Copy link
Contributor Author

bretg commented Aug 12, 2024

Should be in PBS-Java this week. @bsardo - is this in the queue for PBS-Go?

@bretg
Copy link
Contributor Author

bretg commented Aug 14, 2024

Released with PBS-Java 3.9. Discussed in committee - this is on the radar for PBS-Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Dev
Development

No branches or pull requests

3 participants