Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping stored-request ID, targeting in floors #2292

Open
bretg opened this issue Jul 6, 2022 · 3 comments
Open

Keeping stored-request ID, targeting in floors #2292

bretg opened this issue Jul 6, 2022 · 3 comments
Labels

Comments

@bretg
Copy link
Contributor

bretg commented Jul 6, 2022

Early feedback on the floor feature is that being able to target floors by adslot would help publisher performance. However, we don't often get the 'gptSlot' or 'pbAdSlot' in App and AMP scenarios.

But we do almost always get a storedrequest.id, which is a pretty good stand-in for adunit.

So I propose that Prebid Server should keep the storedrequest object instead of removing it. i.e. modules and adapters could look inimp.ext.prebid.storedrequest.id

Alternately, we could push this burden to the contents of the stored request entry. i.e. push the problem to the host companies to remember to add this value to each DB entry. But since that value could get out of sync with reality, it's safer to have PBS keep the actual value used.

Either way, we'll then create a new 'adUnitCode' floors targeting to use this hunt path:

  • imp.ext.gpid
  • imp.tagid
  • imp.ext.data.pbadslot
  • imp.ext.prebid.storedrequest.id

Finally, we'll deprecate the "pbAdSlot" floors targeting parameter -- adUnitCode is what used in client-side floors module.

@bretg
Copy link
Contributor Author

bretg commented Jul 8, 2022

Discussed in PBS committee. It was brought up that publishers may have input on this proposal.

Here's a summary of the question for pubs: "would it be ok for Prebid Server to surface stored-request-ids as a stand-in for adunits?"

A stored-request ID is a key used in app and AMP scenarios that indexes into a set of bidders and parameters. There's also been some interest in Prebid.js to utilize server-side lookup of bidders.

Currently, the stored-request ID is not available to bid adapters and modules, but we're proposing that it would be useful in scenarios where there's not some other kind of adunit information like GPID or PB ad slot.

Specifically, the first use case will be for floor optimization, but there could be other use cases for bid optimization.

@bretg
Copy link
Contributor Author

bretg commented Jul 14, 2022

Discussed today with the publisher task force. There was no concern about sensitivity of having this value available to downstream code. The only comment was that it's possible, like gptSlot, storedRequest might not be granular enough to truly use as gpid. For that, I'll talk to the SDK team to see whether apps can somehow already specify imp.ext.gpid.

@bretg
Copy link
Contributor Author

bretg commented Sep 25, 2024

This was done with PBS-Java 1.101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Dev
Development

No branches or pull requests

2 participants