Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid 7: prevent Prebid from being loaded multiple times #8508

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

dgirardi
Copy link
Collaborator

@dgirardi dgirardi commented Jun 1, 2022

Type of change

  • Build related changes

Description of change

This reworks the way bundles are generated to remove some useless comments/strings, and adds a check to disable loading if Prebid has already been loaded (using the same globalVarName).

Other information

Resolves #8374
Prebid 7 tracking issue: #7796

Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@patmmccann patmmccann merged commit 1f648fd into prebid:prebid-7 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'makeBidRequests')
5 participants