Add adrelevantis adapter

[ghguo]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

• test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

[bretg]

Docs PR prebid/prebid.github.io#2329

[jsnellbaker]

Hi @ghguo

I checked through the code and it largely seems good. There are a few items that should be reviewed and addressed.

I tested the 3 different media types using the parameters in the md file and they rendered successfully.

I checked the test-coverage and it was just a bit below the accepted threshold. It was at 74.41% and we'd like to see at least 80%. Could you take a look at the unit tests and either add tests or modify the existing ones to improve the coverage?

I think we should good once the above is addressed.

Thanks.

[jsnellbaker]

You don't need to read the window object here to see if pbjs is defined. Prebid operates off its own global (so it may be different for some publisher implementations).

Additionally you can use config.getConfig('fpd') here instead of calling window.pbjs.getConfig('fpd').

[jsnellbaker]

You can remove this block if you're not planning to use the onBidWon function.

[jsnellbaker]

If you're not planning to support adpod you can likely remove this part of the if condition.

[ghguo]

Hi jsnellbaker,

The suggested changes have been made. Please advise.

Thanks,
Gary

[jsnellbaker]

Thanks for making the updates; LGTM