Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add verizon alias to aol #5722

Merged
merged 2 commits into from
Sep 11, 2020
Merged

add verizon alias to aol #5722

merged 2 commits into from
Sep 11, 2020

Conversation

ETNOL
Copy link
Contributor

@ETNOL ETNOL commented Sep 9, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other (quality of life)

Description of change

AOL is Verizon. Adds a Verizon alias to their bid adapter. Quality of life change.

@smenzer smenzer self-assigned this Sep 10, 2020
Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smenzer smenzer merged commit 3c6e075 into prebid:master Sep 11, 2020
@slimkrazy
Copy link
Contributor

@ETNOL & @smenzer

I'm afraid that AOL != Verizon. AOL is actually Verizon Media, a subsidiary and our product team would really prefer for this to be aliased as such (something I was only recently asked to change).

@ETNOL - This change is very recent and undocumented, so I would really like to change this to use the correct branding. I can only assume that you made this change for your implementations, so would you and the Prebid maintainers object to me altering this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants