Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No bid version 1.2.8 #5630

Merged
merged 11 commits into from
Sep 21, 2020
Merged

No bid version 1.2.8 #5630

merged 11 commits into from
Sep 21, 2020

Conversation

redaguermas
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Added support for GDPR/TCF 2.0

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

redaguermas and others added 9 commits March 4, 2020 15:39
@redaguermas
Enable supplyChain support
0eba11e
@redaguermas
Added support for COPPA
c0fb8ee
@redaguermas
Merge branch 'master' of https://github.com/prebid/Prebid.js
36fab76 
* 'master' of https://github.com/prebid/Prebid.js: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
@redaguermas
Merge branch 'master' of https://github.com/prebid/Prebid.js
51525d7 
* 'master' of https://github.com/prebid/Prebid.js: (102 commits)
  Marsmedia - Add vastXml and fix id response (prebid#5067)
  PubMatic adapter to support image sync (prebid#5104)
  minor consentManagement fix (prebid#5050)
  fix circle ci failing tests (prebid#5113)
  Add Relaido Adapter (prebid#5101)
  Add new bid adapter for ConnectAd (prebid#4806)
  change payload (prebid#5105)
  Utils updates (prebid#5092)
  Read OpenRTB app objects if set in config + bug fix for when ad units are reloaded (prebid#5086)
  Criteo : added first party data mapping to bidder request (prebid#4954)
  updateAdGenerationManual (prebid#5032)
  New bid adapter: Wipes (prebid#5051)
  Prebid manager analytics utm tags (prebid#4998)
  CRITEO RTUS Integration with Yieldmo Prebid (prebid#5075)
  isSafariBrowser update  (prebid#5077)
  Support min &max duration for onevideo (prebid#5079)
  increment pre version
  Prebid 3.15.0 release
  prebid#5011 Fix to set Secure attribute on cookie when SameSite=none (prebid#5064)
  Prebid adapter for windtalker (prebid#5040)
  ...
Merge remote-tracking branch 'upstream/master'
c473780
Merge branch 'master' of https://github.com/prebid/Prebid.js
33757b8
Merge branch 'master' of https://github.com/prebid/Prebid.js
9e1758b
Merge branch 'master' of https://github.com/prebid/Prebid.js
1d7db5d
Added support for TCF 2.0
7013d14
@redaguermas
Copy link
Contributor Author

This error is unrelated to our code. Can you double-check please?

@robertrmartinez
Copy link
Collaborator

@redaguermas Please add unit tests

musikele
musikele suggested changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as said in another comment, please add unit tests to keep the code coverage greater than 80%, but I encourage to test as much as you can. Thank you

@redaguermas
Copy link
Contributor Author

The test-coverage does not work. Is it working for you?

gulp test-coverage
[16:58:25] Using gulpfile ~/Documents/work/nobid/Prebid.js/gulpfile.js
[16:58:25] Starting 'test-coverage'...
[16:58:25] Starting 'clean'...
[16:58:25] Finished 'clean' after 10 ms
[16:58:25] Starting 'testCoverage'...

START:
ℹ ｢wdm｣:
ℹ ｢wdm｣: Compiled successfully.
ℹ ｢wdm｣: Compiling...
ℹ ｢wdm｣: Failed to compile.
26 08 2020 16:58:47.749:INFO [karma-server]: Karma v4.4.1 server started at http://0.0.0.0:9876/
26 08 2020 16:58:47.750:INFO [launcher]: Launching browsers ChromeHeadless with concurrency 5
26 08 2020 16:58:47.755:INFO [launcher]: Starting browser ChromeHeadless
26 08 2020 16:58:48.077:INFO [HeadlessChrome 84.0.4147 (Mac OS X 10.15.4)]: Connected on socket P5D7-7TxrFvaFTdvAAAA with id 42175759
26 08 2020 16:58:50.097:WARN [reporter]: SourceMap position not found for trace: Uncaught Error: Cannot find module "src/adloader.js"
at http://localhost:9876/base/test/test_index.js?dc5396d26193ca2528d42dc43b9d6782966d7e60:11837:1

Error: Cannot find module "src/adloader.js"
at Object. (http://localhost:9876/base/test/test_index.js?dc5396d26193ca2528d42dc43b9d6782966d7e60:11837:7)
at webpack_require (http://localhost:9876/base/test/test_index.js?dc5396d26193ca2528d42dc43b9d6782966d7e60:20:30)
at Object. (http://localhost:9876/base/test/test_index.js?dc5396d26193ca2528d42dc43b9d6782966d7e60:31966:1)
at webpack_require (http://localhost:9876/base/test/test_index.js?dc5396d26193ca2528d42dc43b9d6782966d7e60:20:30)
at http://localhost:9876/base/test/test_index.js?dc5396d26193ca2528d42dc43b9d6782966d7e60:63:18
at http://localhost:9876/base/test/test_index.js?dc5396d26193ca2528d42dc43b9d6782966d7e60:66:10
HeadlessChrome 84.0.4147 (Mac OS X 10.15.4) ERROR
Uncaught Error: Cannot find module "src/adloader.js"
at webpack:///test/mocks/adloaderStub.js:2:1 <- test/test_index.js:11837:1

Error: Cannot find module "src/adloader.js"
at Object. (webpack:///test/mocks/adloaderStub.js:2:1 <- test/test_index.js:11837:7)
at webpack_require (webpack:///webpack/bootstrap%20a27aaf5067d3fb4ce44d:19:1 <- test/test_index.js:20:30)
at Object. (webpack:///test/test_index.js:2:1 <- test/test_index.js:31966:1)
at webpack_require (webpack:///webpack/bootstrap%20a27aaf5067d3fb4ce44d:19:1 <- test/test_index.js:20:30)
at webpack:///webpack/bootstrap%20a27aaf5067d3fb4ce44d:62:1 <- test/test_index.js:63:18
at test/test_index.js:66:10

Finished in 2.032 secs / 0 secs @ 16:58:50 GMT-0700 (Pacific Daylight Time)

SUMMARY:
✔ 0 tests completed

@redaguermas
Copy link
Contributor Author

@musikele ,
Can you please review my last comment?

-Thanks

@musikele
Copy link
Contributor

musikele commented Sep 4, 2020 •
edited
Loading

Hi @redaguermas , I can run tests just fine. You may need to delete node_modules folder and do npm install again. Also, currently there is anoter module that has failing tests. To get around this issue, you can comment out or skip the offending tests.
Another thing that could help, instead of using gulp test-coverage directly, use npx gulp test-coverage. The difference is that gulp test-coverage will try to use globally-installed gulp, that may be of a different version respect to the one of prebidjs. By using npx, you are explicitly using the version used by prebid.
Hope that helps. Let me know if you succeed.

Small add after few days: check the nodejs version. The latest LTS release (v12.x) is the one I'm currently using.

@redaguermas
Copy link
Contributor Author

@musikele
The error seems unrelated to our Adapter changes.

@redaguermas
Copy link
Contributor Author

@robertrmartinez , I added unit tests and the coverage is >80%.
The CI error is not related to our Adapter changes.

musikele
musikele approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@musikele musikele merged commit 743d6fc into prebid:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musikele musikele musikele approved these changes

Assignees

@musikele musikele

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redaguermas @robertrmartinez @musikele