Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Liveramp userId submodule & read sizes from adUnit.mediaTypes.banner #5436

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

ix-prebid-support
Copy link
Contributor

@ix-prebid-support ix-prebid-support commented Jun 29, 2020

Type of change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • Added support for Liveramp userId submodule
  • The adapter now reads sizes from adUnit.mediaTypes.banner directly and send any missing size(s) found as a part of the bid request as well

@ix-prebid-support ix-prebid-support changed the title Added support for Liveramp userId submodule Added support for Liveramp userId submodule & read sizes from adUnit.mediaTypes.banner Jul 13, 2020
@ix-prebid-support
Copy link
Contributor Author

hi @bmwcmw @mike-chowla,

Any ETA on when this can be reviewed and merged?

@mike-chowla mike-chowla self-requested a review July 14, 2020 15:04
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I thought about asking you use the pre-generated eids array but given you are tracking which ids get added and augmenting it, there wouldn't be any code saving since you'd still ned the code to add entries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants