-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audigent Segmentation Real-time Data Provider #4834
Conversation
@anthonylauzon - sorry, we're backed up. But just skimming this in a few seconds, I notice that you haven't provided unit tests. Please add them. We require 80% coverage.https://github.com/prebid/Prebid.js/tree/master/test/spec/modules More importantly though, I don't understand what your module is actually doing. Note that I'm semi-technical, but don't have a lot of time to dig into this. Please explain how it's supposed to make the user segments available to bid adapters and why it needs a .
|
@brettg can you point me at a RTD module that has a unit test example? This real-time data module provides first-party Audigent segments that can be attached to bid request objects destined for different SSPs in order to optimize targeting. Audigent maintains a large database of first-party Tradedesk Unified ID to third party segment mappings that can now be queried at bid-time. |
Not sure why CircleCI is failing but 'gulp lint' is working on my machine |
@bretg can you kick off another CircleCI build? I am not sure what these failures are resulting from. |
Hello @anthonylauzon , I have triggered the CI job again, let's see. |
Hello @anthonylauzon
|
@pm-harshad-mane i've made the changes requested. it's not clear to me why CircleCI is failing. Are there non-deterministic tests in master? |
@anthonylauzon the CI job is failing due to reasons unrelated to the changes you have made, I have restarted the CI job. |
I think that the PR is ready for merge. Are there any other modifications you would like made? |
@anthonylauzon can you provide test credentials to try-out Audigent module? |
@pm-harshad-mane no credentials needed. just run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @anthonylauzon
Thank you for providing a test-page, can you please add link to the test-page in the audigentRtdProvider.md ?
Integration example added to the readme. |
I tried to load the test page you mentioned above with the noted modules, but it seems like I'm hitting a CORS error against the endpoint:
I noticed the |
@jsnellbaker you will need to use a localhost CORS allowing extension to allow the request to load or disable CORS for localhost in the browser. |
* audigentRtdProvider * fix line error * fix tests * deep equal test fix * conditionally set data in html5 local storage, add markdown readme * add integration test instructions to audigent readme
Type of change
Description of change
This changeset adds a real time data module for retrieving Audigent user segmentation data for unified ids. Using this real time data module, rtb adapters can supply rich segmentation data at request time in order to better target audiences.
Audigent is a next-generation data management platform and a first-of-a-kind "data agency" containing some of the most exclusive content-consuming audiences across desktop, mobile and social platforms.