Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground XYZ adapter - iframe usersync bug fix #4141

Merged
merged 7 commits into from
Sep 5, 2019

Conversation

monofonik
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • Fixes a bug where "image" type user sync pixels are not being dropped when the publisher allows iframe usersync.
  • Removes a redundant iframe sync pixel URL from the Playground XYZ adapter code.

Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a unit test confirming that the adapter responds with an image regardless of syncOptions

@bretg bretg self-assigned this Sep 3, 2019
@monofonik
Copy link
Contributor Author

Thanks @bretg PR updated. Noticed the CircleCI build is failing - but doesn't appear to be an issue with my changes?

@bretg
Copy link
Collaborator

bretg commented Sep 4, 2019

Thanks - looks good. CircleCI has been kinda flaky lately. Re-running.

@bretg
Copy link
Collaborator

bretg commented Sep 4, 2019

@monofonik - please resync this PR with master. I'm told that may eliminate the circleci problem. I've re-run this several times to no avail.

@monofonik
Copy link
Contributor Author

Thanks @bretg updated looks good now

@bretg bretg merged commit 67e3a9c into prebid:master Sep 5, 2019
@bretg
Copy link
Collaborator

bretg commented Sep 5, 2019

Merged. While I have your attention here, would like to pick up or close out prebid/prebid.github.io#1203

@monofonik
Copy link
Contributor Author

Thanks @bretg I'll reply on the other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants