-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground XYZ adapter - iframe usersync bug fix #4141
Playground XYZ adapter - iframe usersync bug fix #4141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a unit test confirming that the adapter responds with an image regardless of syncOptions
Thanks @bretg PR updated. Noticed the CircleCI build is failing - but doesn't appear to be an issue with my changes? |
Thanks - looks good. CircleCI has been kinda flaky lately. Re-running. |
@monofonik - please resync this PR with master. I'm told that may eliminate the circleci problem. I've re-run this several times to no avail. |
…move-iframe-usersync
Thanks @bretg updated looks good now |
Merged. While I have your attention here, would like to pick up or close out prebid/prebid.github.io#1203 |
Thanks @bretg I'll reply on the other PR |
Type of change
Description of change