Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event firing on native click #3589

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Fix event firing on native click #3589

merged 1 commit into from
Mar 1, 2019

Conversation

matthewlane
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

Fixes bug where BID_WON event was firing when a native click track message was received. The BID_WON event for a native ad will still fire when the 'Prebid Native' message is received when the ad initially loads, but won't happen again for clicks fired from that ad

Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harpere harpere added the needs 2nd review Core module updates require two approvals from the core team label Feb 28, 2019
@jsnellbaker jsnellbaker self-requested a review March 1, 2019 19:46
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit dd26503 into master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants