Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop generating "NO_BID" bids for rejected bids #9722

Closed
ChrisHuie opened this issue Mar 28, 2023 · 2 comments · Fixed by #9902
Closed

Stop generating "NO_BID" bids for rejected bids #9722

ChrisHuie opened this issue Mar 28, 2023 · 2 comments · Fixed by #9902
Assignees
@robertrmartinez
Labels
8.0 API Change

Comments

@ChrisHuie
Copy link
Collaborator

In reference to different way Prebid rejected bids. That main issue was addressed here #8956. This is the final bullet point that needed to be done in a major version. Since auction.bidsReceived only contains valid bids we should stop generating NO_BID for rejected bids.
@dgirardi dgirardi mentioned this issue May 3, 2023
Merged
1 task
@patmmccann
Copy link
Collaborator

Adding @robertrmartinez as assignee so Rubicon analytics can fix tests to clear the way for this PR

@robertrmartinez
Copy link
Collaborator

Rubicon Analytics has been removed from Prebid 8 branch as it is replaced by the Magnite Analytics Adapter.

Here is the PR in magnite analytics prebid-8 branch to not rely on this 0 cpm bid response stuff! #9933

@patmmccann patmmccann linked a pull request May 25, 2023 that will close this issue
Prebid 8: remove NO_BID bids #9902
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertrmartinez robertrmartinez

Labels
8.0 API Change
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prebid 8: remove NO_BID bids dgirardi/Prebid.js
3 participants
@patmmccann @ChrisHuie @robertrmartinez