Our ci/circleci: build always fails. smartclipBidAdapter #5275

[smartclip-adtech]

Type of issue

Question

Description

Our ci/circleci: build always fails.
350:7 error Identifier 'sc_smartIntxtStart' is not in camel case camelcase

351:7 error Identifier 'sc_smartIntxtNoad' is not in camel case camelcase

352:7 error Identifier 'sc_smartIntxtEnd' is not in camel case camelcase

We can't rename the sc_smartIntxt function to camelcase.
This is a function we use for our outstream player.

What can we do here?
Is there a supporter who can give us some help to join prebid.org?

Steps to reproduce

Pull Request smartclipBidAdapter #5275

Test page

Expected results

Actual results

Platform details

Other information

[jsnellbaker]

@smartclip-adtech

If these are lint errors, you can try to insert the following comment on the line(s) above where you use this function:
// eslint-disable-next-line camelcase

That said when I looked at the referenced PR and the subsequent circleci job - that was running off of the smartclip-adtech organization, not the Prebid.js organization. So the job may not be running with the ideal set of rules.

To fix this problem, I think you'd need to log into circleci and un-follow the Prebid.js fork in your local group (should be under Settings > Organization Projects). The next commit you would make should run under the Prebid.js organization in circleci.

Please let me know if you have any questions on the above.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[smartclip-adtech]

Hi,

thanks.
But now we have another issue.
The adapter is still "in review" - i don't know why.
Is there anything we have to do now?

Best Regards

[jsnellbaker]

@smartclip-adtech I'll grab the PR and give it a review today.

[jsnellbaker]

I'm going to close this issue for now since it seems the lint errors were addressed in the PR and the review has started.