Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native ads not working without adUnit.sizes #2462

Closed
jaiminpanchal27 opened this issue Apr 27, 2018 · 1 comment
Closed

Native ads not working without adUnit.sizes #2462

jaiminpanchal27 opened this issue Apr 27, 2018 · 1 comment
Assignees
Labels

Comments

@jaiminpanchal27
Copy link
Collaborator

Type of issue

Bug

Description

Test page: https://jsfiddle.net/6r217wza/
Native ads should not require size to be mentioned on adUnit. Above test page will work if you uncomment the adUnit.sizes

Debug mode shows callBids executed with no bidRequests. Were they filtered by labels or sizing?
Reason for filtering is here

@snapwich
Copy link
Collaborator

@jaiminpanchal27 the size mapping probably needs to be refactored. When I originally wrote it there was no such thing as mediaTypes, so it operates on adUnit.sizes alone. But now I guess it should expect and operate on one or the other?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants