-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Module Doesn't Push Winning Bids to Auction Winning Bids State #10008
Comments
I am wondering if this is limited to the video module, or if it's a problem for video in general. The video module calls However, that seems to only mark the bid as "rendered", and not as winning, and I don't know why - it seems to have been like this since the beginning. Paging @mkendall07 for the slim chance of some context. |
@ChrisHuie or @karimMourra, are you able to confirm if this is the same issue as in #9686 and/or #9561 ? |
I had already fixed this in https://github.com/prebid/Prebid.js/pull/9612/files but it seems like my changes were deleted. the git blame for that line indicates a commit from 2018. |
I am also confused by your commit. With some digging it looks like it was erased with a heavy handed conflict merge. Do you see anything else in there that may also be broken? |
I don't see anything else that looks broken in the conflict merge. |
Type of issue
Bug
Description
The Prebid video module doesn't add winning bids to the
_winningBids
state of an auction. This is because thepbjsRenderAd
function doesn't run when a video ad unit plays:https://github.com/prebid/Prebid.js/blob/master/src/prebid.js#L528
Steps to reproduce
Implement the video module on a test page and have some bids win the auction and play. Then type
pbjs.getAllWinningBids()
and notice how it's empty.The text was updated successfully, but these errors were encountered: