convert bidders: brave

prebid · May 20, 2022 · a237df5 · a237df5
1 parent 94337ef
commit a237df5
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 20 deletions.
diff --git a/modules/admanBidAdapter.js b/modules/admanBidAdapter.js
@@ -65,6 +65,7 @@ export const spec = {
   buildRequests: (validBidRequests = [], bidderRequest) => {
     let winTop = window;
     let location;
+    // TODO: this odd try-catch block was copied in several adapters; it doesn't seem to be correct for cross-origin
     try {
       location = new URL(bidderRequest.refererInfo.page)
       winTop = window.top;

diff --git a/modules/adprimeBidAdapter.js b/modules/adprimeBidAdapter.js
@@ -52,6 +52,7 @@ export const spec = {
   buildRequests: (validBidRequests = [], bidderRequest) => {
     let winTop = window;
     let location;
+    // TODO: this odd try-catch block was copied in several adapters; it doesn't seem to be correct for cross-origin
     try {
       location = new URL(bidderRequest.refererInfo.page)
       winTop = window.top;

diff --git a/modules/bluebillywigBidAdapter.js b/modules/bluebillywigBidAdapter.js
@@ -306,7 +306,7 @@ export const spec = {
     if (getConfig('coppa') == true) deepSetValue(request, 'regs.coppa', 1);
 
     // Enrich the request with any external data we may have
-    BB_HELPERS.addSiteAppDevice(request, bidderRequest.refererInfo && bidderRequest.refererInfo.referer);
+    BB_HELPERS.addSiteAppDevice(request, bidderRequest.refererInfo && bidderRequest.refererInfo.page);
     BB_HELPERS.addSchain(request, validBidRequests);
     BB_HELPERS.addCurrency(request);
     BB_HELPERS.addUserIds(request, validBidRequests);

diff --git a/modules/boldwinBidAdapter.js b/modules/boldwinBidAdapter.js
@@ -51,8 +51,9 @@ export const spec = {
   buildRequests: (validBidRequests = [], bidderRequest) => {
     let winTop = window;
     let location;
+    // TODO: this odd try-catch block was copied in several adapters; it doesn't seem to be correct for cross-origin
     try {
-      location = new URL(bidderRequest.refererInfo.referer)
+      location = new URL(bidderRequest.refererInfo.page)
       winTop = window.top;
     } catch (e) {
       location = winTop.location;

diff --git a/modules/braveBidAdapter.js b/modules/braveBidAdapter.js
@@ -62,23 +62,9 @@ export const spec = {
       return impObject;
     });
 
-    let w = window;
-    let l = w.document.location.href;
-    let r = w.document.referrer;
-
-    let loopChecker = 0;
-    while (w !== w.parent) {
-      if (++loopChecker == 10) break;
-      try {
-        w = w.parent;
-        l = w.location.href;
-        r = w.document.referrer;
-      } catch (e) {
-        break;
-      }
-    }
-
-    let page = l || bidderRequest.refererInfo.referer;
+    // TODO: do these values make sense?
+    let page = bidderRequest.refererInfo.page || bidderRequest.refererInfo.topmostLocation;
+    let r = bidderRequest.refererInfo.ref;
 
     let data = {
       id: bidderRequest.bidderRequestId,

diff --git a/test/spec/modules/bluebillywigBidAdapter_spec.js b/test/spec/modules/bluebillywigBidAdapter_spec.js
@@ -439,7 +439,7 @@ describe('BlueBillywigAdapter', () => {
     it('should add referrerInfo as site when no app is set', () => {
       const newValidBidderRequest = deepClone(validBidderRequest);
 
-      newValidBidderRequest.refererInfo = { referer: 'https://www.bluebillywig.com' };
+      newValidBidderRequest.refererInfo = { page: 'https://www.bluebillywig.com' };
 
       const request = spec.buildRequests(baseValidBidRequests, newValidBidderRequest);
       const payload = JSON.parse(request.data);