fix: Types w/ module augmentation #4884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently module augmentation affects how consumers within
node_modulesget augmented types, as the following in user code wouldn't work:As
jsx.d.tsimports fromdom.d.ts, the snippet above wouldn't augment that interface and so the JSX types would remain unchanged for the user; instead,jsx.d.tsneeds to import everything from thepreactnamespace directly to ensure users can overwrite/extend easily.