-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSX type errors on React Bootstrap 2.x & Preact 10.x #4425
Comments
Please provide a minimal reproduction, it's not fair to ask maintainers to browser through a full project. |
@rschristian That repository is not a full project, it's just a scaffold with some simple example pages, but almost every page & component has the same type errors... |
Anything more than a few files in This is the example StackBlitz we provide in the bug template, which is just about ideal for a web reproduction. For type errors you could certainly go even more minimal. |
Thanks, but Parcel 2.x is my real bundler, not Vite: https://codesandbox.io/p/devbox/preact-react-bootstrap-llqsv9?file=%2Fsrc%2Findex.tsx%3A5%2C14 |
Build tooling isn't likely to matter in a types issue, but regardless, it's just an example of scope that's appropriate. But thanks, the minimal repro does help. Looks like we'll need to widen - (props: RenderableProps<P>, context?: any): VNode<any> | null;
+ (props: RenderableProps<P>, context?: any): ComponentChild;
Line 90 in eb37677
Will need to play around with this for a bit. |
My Web components engine may have the same issue😂 (PReact's JSX type definition is my major reference instead of confusing |
Describe the bug
Every React Bootstrap component with Preact has a similar error as shown below:
To Reproduce
Steps to reproduce the behavior
git clone https://github.com/idea2app/React-MobX-Bootstrap-ts
npm i
npx tsc --noEmit
Expected behavior
No type errors as React does.
The text was updated successfully, but these errors were encountered: