From 65563e4c0bc31586d2ca9f9e9ca9e2f6741a3819 Mon Sep 17 00:00:00 2001
From: Ryan Christian <rchristian@ryanchristian.dev>
Date: Sat, 12 Oct 2024 00:04:12 -0500
Subject: [PATCH] refactor: Warn on NaN in dep arrays instead of throwing

---
 debug/src/debug.js                          |  2 +-
 debug/test/browser/validateHookArgs.test.js | 21 ++++++++++++++-------
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/debug/src/debug.js b/debug/src/debug.js
index ae92dd3d0a..221d8f202b 100644
--- a/debug/src/debug.js
+++ b/debug/src/debug.js
@@ -483,7 +483,7 @@ export function initDebug() {
 							const arg = hook._args[j];
 							if (isNaN(arg)) {
 								const componentName = getDisplayName(vnode);
-								throw new Error(
+								console.warn(
 									`Invalid argument passed to hook. Hooks should not be called with NaN in the dependency array. Hook index ${i} in component ${componentName} was called with NaN.`
 								);
 							}
diff --git a/debug/test/browser/validateHookArgs.test.js b/debug/test/browser/validateHookArgs.test.js
index 19f7cb7fd3..5e2b6b6d3b 100644
--- a/debug/test/browser/validateHookArgs.test.js
+++ b/debug/test/browser/validateHookArgs.test.js
@@ -31,18 +31,21 @@ describe('Hook argument validation', () => {
 		};
 
 		it(`should error if ${name} is mounted with NaN as an argument`, async () => {
-			expect(() =>
-				render(<TestComponent initialValue={NaN} />, scratch)
-			).to.throw(/Hooks should not be called with NaN in the dependency array/);
+			render(<TestComponent initialValue={NaN} />, scratch);
+			expect(console.warn).to.be.calledOnce;
+			expect(console.warn.args[0]).to.match(
+				/Hooks should not be called with NaN in the dependency array/
+			);
 		});
 
 		it(`should error if ${name} is updated with NaN as an argument`, async () => {
 			render(<TestComponent initialValue={0} />, scratch);
 
-			expect(() => {
-				scratch.querySelector('button').click();
-				rerender();
-			}).to.throw(
+			scratch.querySelector('button').click();
+			rerender();
+
+			expect(console.warn).to.be.calledOnce;
+			expect(console.warn.args[0]).to.match(
 				/Hooks should not be called with NaN in the dependency array/
 			);
 		});
@@ -52,14 +55,18 @@ describe('Hook argument validation', () => {
 	let scratch;
 	/** @type {() => void} */
 	let rerender;
+	let warnings = [];
 
 	beforeEach(() => {
 		scratch = setupScratch();
 		rerender = setupRerender();
+		warnings = [];
+		sinon.stub(console, 'warn').callsFake(w => warnings.push(w));
 	});
 
 	afterEach(() => {
 		teardown(scratch);
+		console.warn.restore();
 	});
 
 	validateHook('useEffect', arg => useEffect(() => {}, [arg]));