Skip to content

Commit 63e5525

Browse files
committed
Remove contains with a simple parentNode check (#4666)
1 parent e9b345e commit 63e5525

File tree

3 files changed

+1
-3
lines changed

3 files changed

+1
-3
lines changed

src/diff/children.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ function insert(parentVNode, oldDom, parentDom) {
358358

359359
return oldDom;
360360
} else if (parentVNode._dom != oldDom) {
361-
if (oldDom && parentVNode.type && !parentDom.contains(oldDom)) {
361+
if (oldDom && parentVNode.type && !oldDom.parentNode) {
362362
oldDom = getDomSibling(parentVNode);
363363
}
364364
parentDom.insertBefore(parentVNode._dom, oldDom || NULL);

src/index-5.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,6 @@ interface ContainerNode {
290290
readonly firstChild: ContainerNode | null;
291291
readonly childNodes: ArrayLike<ContainerNode>;
292292

293-
contains(other: ContainerNode | null): boolean;
294293
insertBefore(node: ContainerNode, child: ContainerNode | null): ContainerNode;
295294
appendChild(node: ContainerNode): ContainerNode;
296295
removeChild(child: ContainerNode): ContainerNode;

src/index.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,6 @@ interface ContainerNode {
289289
readonly firstChild: ContainerNode | null;
290290
readonly childNodes: ArrayLike<ContainerNode>;
291291

292-
contains(other: ContainerNode | null): boolean;
293292
insertBefore(node: ContainerNode, child: ContainerNode | null): ContainerNode;
294293
appendChild(node: ContainerNode): ContainerNode;
295294
removeChild(child: ContainerNode): ContainerNode;

0 commit comments

Comments
 (0)