Skip to content

refactor: Inline SVG defs #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+39 −37
Open

refactor: Inline SVG defs #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,42 @@
<link href="https://www.google-analytics.com" rel="preconnect" crossorigin="anonymous">
</head>
<body class="banner">
<svg xmlns="http://www.w3.org/2000/svg" style="display: none;">
Copy link
Member Author

@rschristian rschristian Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively could keep this separate & just write a Vite plugin to inline it into the HTML, dunno if that's better or worse.

<defs>
<symbol id="github" viewBox="0 0 24 24">
<path d="M12 0c-6.626 0-12 5.373-12 12 0 5.302 3.438 9.8 8.207 11.387.599.111.793-.261.793-.577v-2.234c-3.338.726-4.033-1.416-4.033-1.416-.546-1.387-1.333-1.756-1.333-1.756-1.089-.745.083-.729.083-.729 1.205.084 1.839 1.237 1.839 1.237 1.07 1.834 2.807 1.304 3.492.997.107-.775.418-1.305.762-1.604-2.665-.305-5.467-1.334-5.467-5.931 0-1.311.469-2.381 1.236-3.221-.124-.303-.535-1.524.117-3.176 0 0 1.008-.322 3.301 1.23.957-.266 1.983-.399 3.003-.404 1.02.005 2.047.138 3.006.404 2.291-1.552 3.297-1.23 3.297-1.23.653 1.653.242 2.874.118 3.176.77.84 1.235 1.911 1.235 3.221 0 4.609-2.807 5.624-5.479 5.921.43.372.823 1.102.823 2.222v3.293c0 .319.192.694.801.576 4.765-1.589 8.199-6.086 8.199-11.386 0-6.627-5.373-12-12-12z" fill="#fff"/>
</symbol>

<symbol id="twitter" viewBox="0 0 34 27.646">
<path d="M10.68 27.646c12.83 0 19.85-10.64 19.85-19.85 0-.3 0-.599-.013-.898A14.213 14.213 0 0 0 34 3.278a14.14 14.14 0 0 1-4.014 1.103A7.02 7.02 0 0 0 33.061.517a13.877 13.877 0 0 1-4.435 1.687A6.963 6.963 0 0 0 23.537 0c-3.85 0-6.98 3.13-6.98 6.98 0 .544.069 1.074.178 1.591-5.796-.285-10.94-3.074-14.381-7.292a6.978 6.978 0 0 0-.939 3.51 6.995 6.995 0 0 0 3.102 5.81 7.057 7.057 0 0 1-3.156-.871v.095a6.991 6.991 0 0 0 5.591 6.844 6.802 6.802 0 0 1-1.836.245c-.45 0-.885-.041-1.306-.123a6.976 6.976 0 0 0 6.517 4.844 13.993 13.993 0 0 1-8.667 2.993c-.558 0-1.116-.027-1.66-.095a19.845 19.845 0 0 0 10.68 3.115" fill="#fff" />
</symbol>

<symbol id="bluesky" viewBox="0 0 568 501" >
<path d="M123.121 33.6637C188.241 82.5526 258.281 181.681 284 234.873C309.719 181.681 379.759 82.5526 444.879 33.6637C491.866 -1.61183 568 -28.9064 568 57.9464C568 75.2916 558.055 203.659 552.222 224.501C531.947 296.954 458.067 315.434 392.347 304.249C507.222 323.8 536.444 388.56 473.333 453.32C353.473 576.312 301.061 422.461 287.631 383.039C285.169 375.812 284.017 372.431 284 375.306C283.983 372.431 282.831 375.812 280.369 383.039C266.939 422.461 214.527 576.312 94.6667 453.32C31.5556 388.56 60.7778 323.8 175.653 304.249C109.933 315.434 36.0535 296.954 15.7778 224.501C9.94525 203.659 0 75.2916 0 57.9464C0 -28.9064 76.1345 -1.61183 123.121 33.6637Z" fill="#fff"/>
</symbol>

<symbol id="slack" viewBox="0 0 512 512" fill="#fff">
<path d="M126.12,315.1A47.06,47.06,0,1,1,79.06,268h47.06Z" />
<path d="M149.84,315.1a47.06,47.06,0,0,1,94.12,0V432.94a47.06,47.06,0,1,1-94.12,0Z" />
<path d="M196.9,126.12A47.06,47.06,0,1,1,244,79.06v47.06Z" />
<path d="M196.9,149.84a47.06,47.06,0,0,1,0,94.12H79.06a47.06,47.06,0,0,1,0-94.12Z" />
<path d="M385.88,196.9A47.06,47.06,0,1,1,432.94,244H385.88Z" />
<path d="M362.16,196.9a47.06,47.06,0,0,1-94.12,0V79.06a47.06,47.06,0,1,1,94.12,0Z" />
<path d="M315.1,385.88A47.06,47.06,0,1,1,268,432.94V385.88Z" />
<path d="M315.1,362.16a47.06,47.06,0,0,1,0-94.12H432.94a47.06,47.06,0,1,1,0,94.12Z" />
</symbol>

<symbol id="i18n" viewBox="0 0 24 24">
<path d="M0 0h24v24H0z" fill="none" />
<path d="M12.87 15.07l-2.54-2.51.03-.03c1.74-1.94 2.98-4.17 3.71-6.53H17V4h-7V2H8v2H1v1.99h11.17C11.5 7.92 10.44 9.75 9 11.35 8.07 10.32 7.3 9.19 6.69 8h-2c.73 1.63 1.73 3.17 2.98 4.56l-5.09 5.02L4 19l5-5 3.11 3.11.76-2.04zM18.5 10h-2L12 22h2l1.12-3h4.75L21 22h2l-4.5-12zm-2.62 7l1.62-4.33L19.12 17h-3.24z" fill="currentColor" />
</symbol>

<symbol id="link" viewBox="0 0 24 24" fill="none" stroke="#fff" stroke-width="2">
<path d="M15 7h3a5 5 0 0 1 5 5 5 5 0 0 1-5 5h-3m-6 0H6a5 5 0 0 1-5-5 5 5 0 0 1 5-5h3"></path>
<line x1="8" y1="12" x2="16" y2="12"></line>
</symbol>
</defs>
</svg>
<div id="app"></div>
<script type="module" src="./src/index.jsx" prerender></script>
</body>
Expand Down
2 changes: 1 addition & 1 deletion plugins/precompile-markdown/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ marked.use({
<h${depth} id="${id}">
<a class="fragment-link" href="#${id}">
<svg width="16" height="16" viewBox="0 0 24 24" aria-label="Link to: ${text} (#${id})">
<use href="/icons.svg#link" />
<use href="#link" />
</svg>
</a>
<span>${text}</span>
Expand Down
34 changes: 0 additions & 34 deletions src/assets/icons.svg
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/components/header/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ function LanguagePicker() {
isOpen={isOpen}
label={
<svg aria-hidden viewBox="0 0 24 24">
<use href="/icons.svg#i18n" />
<use href="#i18n" />
</svg>
}
aria-label={selectYourLanguage}
Expand Down Expand Up @@ -165,7 +165,7 @@ const SocialIcon = ({ label, href, viewbox, id }) => (
rel="noopener noreferrer"
>
<svg aria-hidden viewBox={viewbox}>
<use href={`/icons.svg#${id}`} />
<use href={`#${id}`} />
</svg>
</a>
);
Expand Down