Skip to content

Conversation

thatsmydoing
Copy link

The encode function takes new2old_glyph but was being passed old_to_new_glyph which was causing the calculated metrics to be for the wrong glyphs. I think this should fix #102 (at least for our use case it does).

@johnnyshields
Copy link

johnnyshields commented May 13, 2025

@pointlessone I've tested this in production and it looks good to merge and release.

@yoshoku
Copy link

yoshoku commented May 13, 2025

@pointlessone I've confirmed too that this pull request fixes the issue even when using Japanese TrueType fonts such as Genshin Gothic, similar to #104.

@johnnyshields
Copy link

johnnyshields commented Jun 21, 2025

@pointlessone can you please handle the merge and release of this? I've been using it prod for several months without issue.

@pointlessone
Copy link
Member

Thank you @johnnyshields, I'll get to it eventually.


Unrelated to the PR.

@johnnyshields You've been active in this part of the woods lately so I'm wandering what's the status of your fork. Are you still maintaining it? Have you retired it? Just want to orient myself.

@johnnyshields
Copy link

johnnyshields commented Jun 21, 2025

I haven't spent further time on the Prawn community fork.

As I've continually expressed, my preferences for Prawn are (in this order):

  1. You (@pointlessone) do a proper job in maintaining Prawn.
    • The term "proper" includes not letting easily fixed regressions such as this one go unpatched for months while a confused/bewildered community files countless duplicate issues for the same root cause.
  2. You designate a co-maintainer who can do the proper job given your limited bandwidth. It is fine if such role is limited only to triaging/testing critical issues such as this one. I am glad to assist in such role, and there are plenty of other good options if not me.
  3. We move forward with a community fork, which is a major hassle for everyone, and requires more of my personal time/effort than I really want to spend here.

For a few months you were making solid progress on Prawn, but with this issue it appears momentum is stalling. I hope we see this patch merged soon.

@flavio-b
Copy link

Running this patch in production for about 2 weeks and no problems to report so far. TTF fonts only, and multiple languages.

gem 'prawn', '~> 2.5.0'
gem "ttfunk", "~> 1.8.0", github: "thatsmydoing/ttfunk", branch: "fix-maxp-again"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The Return of the Embedded Font Issue
5 participants