-
Notifications
You must be signed in to change notification settings - Fork 84
Pass correct glyph mapping when encoding maxp #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@pointlessone I've tested this in production and it looks good to merge and release. |
@pointlessone I've confirmed too that this pull request fixes the issue even when using Japanese TrueType fonts such as Genshin Gothic, similar to #104. |
@pointlessone can you please handle the merge and release of this? I've been using it prod for several months without issue. |
Thank you @johnnyshields, I'll get to it eventually. Unrelated to the PR. @johnnyshields You've been active in this part of the woods lately so I'm wandering what's the status of your fork. Are you still maintaining it? Have you retired it? Just want to orient myself. |
I haven't spent further time on the Prawn community fork. As I've continually expressed, my preferences for Prawn are (in this order):
For a few months you were making solid progress on Prawn, but with this issue it appears momentum is stalling. I hope we see this patch merged soon. |
Running this patch in production for about 2 weeks and no problems to report so far. TTF fonts only, and multiple languages.
|
The
encode
function takesnew2old_glyph
but was being passedold_to_new_glyph
which was causing the calculated metrics to be for the wrong glyphs. I think this should fix #102 (at least for our use case it does).