-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weather Notifier Script #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to be done
- Elaborate the README file
- You have a README template to follow in README file of the project.
- Add project title to your PR. Just adding PR title as "weather" won't say what your project is.
- This is a weather notifier script. The file name as well should be as weather_notifier.py
Kindly do the needful changes. @Komal-99
Okay template one i will do but I don't have content for readme.md so shall i leave it that's it? |
Ok no issue. You can. Do the template one. Also add the info about the issue in PR commit message. @Komal-99 |
Done |
Check the above comment |
yes i did and i have fulfill rest two points of editing name of PR and renaming .py file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR is approved and merged successfully. Finally, you did it. Congrats. Keep contributing. @Komal-99
yeah finally so now can i create new Issue for Covid bot which give notification about total cases recovered and deaths? |
Yes, finally you can. Is covid bot an automation script? @Komal-99 |
Yes
|
Ok, cool you can raise an issue stating the same using template. @Komal-99 |
Related Issue
#120
Info about the related issue
LGM-SOC'21 Participant
Contributor
Closes: #120
Describe the changes you've made
Give a clear description what modifications you have made
Added REAME.md
Added requirements.txt
Added weather.py
Added Images
Type of change
What sort of change have you made:
How Has This Been Tested?
Describe how have you verified the changes made
Checklist:
Screenshots