Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather Notifier Script #163

Merged
merged 10 commits into from
Jun 12, 2021
Merged

Conversation

Komal-99
Copy link
Contributor

@Komal-99 Komal-99 commented Jun 12, 2021

Related Issue

#120

  • Info about the related issue

  • LGM-SOC'21 Participant

  • Contributor

Closes: #120

Describe the changes you've made

Give a clear description what modifications you have made
Added REAME.md
Added requirements.txt
Added weather.py
Added Images

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how have you verified the changes made

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
Original Screenshot Update Screenshot

image

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done

  • Elaborate the README file
  • You have a README template to follow in README file of the project.
  • Add project title to your PR. Just adding PR title as "weather" won't say what your project is.
  • This is a weather notifier script. The file name as well should be as weather_notifier.py

Kindly do the needful changes. @Komal-99

@Komal-99
Copy link
Contributor Author

Okay template one i will do but I don't have content for readme.md so shall i leave it that's it?

@prathimacode-hub prathimacode-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 12, 2021
@Komal-99 Komal-99 changed the title Weather Weather Notifier Script Jun 12, 2021
@prathimacode-hub
Copy link
Owner

prathimacode-hub commented Jun 12, 2021

Okay template one i will do but I don't have content for readme.md so shall i leave it that's it?

Ok no issue. You can. Do the template one. Also add the info about the issue in PR commit message. @Komal-99

@Komal-99
Copy link
Contributor Author

Done

@prathimacode-hub
Copy link
Owner

Done

Check the above comment

@Komal-99
Copy link
Contributor Author

Done

Check the above comment

yes i did and i have fulfill rest two points of editing name of PR and renaming .py file

@prathimacode-hub prathimacode-hub added the 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. label Jun 12, 2021
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is approved and merged successfully. Finally, you did it. Congrats. Keep contributing. @Komal-99

@prathimacode-hub prathimacode-hub merged commit 325a78a into prathimacode-hub:main Jun 12, 2021
@Komal-99 Komal-99 deleted the weather branch June 12, 2021 17:31
@Komal-99
Copy link
Contributor Author

Your PR is approved and merged successfully. Finally, you did it. Congrats. Keep contributing. @Komal-99

yeah finally so now can i create new Issue for Covid bot which give notification about total cases recovered and deaths?

@prathimacode-hub
Copy link
Owner

Yes, finally you can. Is covid bot an automation script? @Komal-99

@Komal-99
Copy link
Contributor Author

Yes

Yes, finally you can. Is covid bot an automation script? @Komal-99
Yes similar to this one

@prathimacode-hub
Copy link
Owner

Ok, cool you can raise an issue stating the same using template. @Komal-99

@prathimacode-hub prathimacode-hub removed the 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. label Jun 24, 2021
@prathimacode-hub prathimacode-hub added the 🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21 & DCP21.Points will be 10 label Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21 & DCP21.Points will be 10 LGMSOC21 This issue will be considered for LGM-SOC 21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weather notification script
2 participants