Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is there any plan to upgrade react dependency to 17 ? #118

Open
passos opened this issue Apr 25, 2021 · 11 comments
Open

is there any plan to upgrade react dependency to 17 ? #118

passos opened this issue Apr 25, 2021 · 11 comments

Comments

@passos
Copy link

passos commented Apr 25, 2021

the library now depends on react 15 & 16. it doesn't work under react 17. I am wondering is there any plan to upgrade the dependency?

@rushi
Copy link

rushi commented May 29, 2021

Maybe some can help out here if they have ideas?

@ramkumarkb
Copy link

Hello,

Is this just a matter of adding ^17.0.0 in the peerDependencies or something more than that?

	"peerDependencies": {
		"react": "^15.3.0 || ^16.0.0 || ^17.0.0",
		"react-dom": "^15.3.0 || ^16.0.0 || ^17.0.0"
	},

@feddyups
Copy link

feddyups commented Jun 9, 2021

@tenacioustechie
Copy link

Is there any progress on updating to support react 17?
I noticed the last release was a year ago so I'm wondering the project is active?

@jmikrut
Copy link

jmikrut commented Feb 6, 2022

Bump - we need this to correct an issue with legacy peer dependencies in Payload.

Can we get the above PR merged in? Everything appears to work with React 17.

@feddyups
Copy link

it doesnt feel like the project is active, I am considering forking this...

@tenacioustechie
Copy link

I would help test/contribute if you do @feddyups

@jonwardopenai
Copy link

I would also help test/contribute.

@oswaldoacauan
Copy link

We are using it with react@18 and seems to work fine. Maybe just remove the peerDependencies restriction?

@herndlm
Copy link

herndlm commented Sep 15, 2022

there seem to be multiple forks already now with https://www.npmjs.com/package/react-diff-viewer-continued being the most popular so far. I think I'm considering switching to that fork for now, maybe the community should consider the same / agree on a fork

@faisal004
Copy link

Thanks @herndlm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants