Skip to content

Commit 4e60bdd

Browse files
committed
fix: refactored code and applied baeldung code formatter
Signed-off-by: Emmanuel Mireku Omari <omariemmanuel91@gmail.com>
1 parent 64e14bc commit 4e60bdd

File tree

2 files changed

+65
-72
lines changed

2 files changed

+65
-72
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
package com.baeldung.math.percentdiffbetweentwonumbers;
22

33
public class PercentDiffBetweenTwoNumbers {
4-
public static double calculatePercentageDifference(double v1, double v2) {
5-
double average = (v1 + v2) / 2;
6-
if (average == 0) {
7-
throw new IllegalArgumentException("The average of V1 and V2 cannot be zero.");
4+
5+
public static double calculatePercentageDifference(double v1, double v2) {
6+
double average = (v1 + v2) / 2;
7+
if (average == 0) {
8+
throw new IllegalArgumentException("The average of v1 and v2 cannot be zero.");
9+
}
10+
return Math.abs((v1 - v2) / average) * 100;
811
}
9-
return Math.abs((v1 - v2) / average) * 100;
10-
}
1112
}

core-java-modules/core-java-lang-math-4/src/test/java/com/baeldung/math/percentdiffbetweentwonumberstest/PercentDiffBetweenTwoNumbersUnitTest.java

Lines changed: 58 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -3,79 +3,71 @@
33
import static org.junit.jupiter.api.Assertions.assertEquals;
44
import static org.junit.jupiter.api.Assertions.assertThrows;
55

6-
import com.baeldung.math.percentdiffbetweentwonumbers.PercentDiffBetweenTwoNumbers;
76
import org.junit.jupiter.api.Test;
7+
8+
import com.baeldung.math.percentdiffbetweentwonumbers.PercentDiffBetweenTwoNumbers;
9+
810
class PercentDiffBetweenTwoNumbersUnitTest {
911

10-
@Test
11-
void whenCalculatePercentageDifferenceBetweenTwoNumbers_thenCorrectResult() {
12-
double v1 = 50.0;
13-
double v2 = 70.0;
14-
double expected = 33.33;
15-
double result = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2);
16-
assertEquals(expected, result, 0.01, "Percentage difference should be correctly calculated.");
17-
}
12+
@Test
13+
void whenCalculatePercentageDifferenceBetweenTwoNumbers_thenCorrectResult() {
14+
double v1 = 50.0;
15+
double v2 = 70.0;
16+
double expected = 33.33;
17+
double result = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2);
18+
assertEquals(expected, result, 0.01, "Percentage difference should be correctly calculated.");
19+
}
1820

19-
@Test
20-
void whenV1AndV2AreEqual_thenPercentageDifferenceIsZero() {
21-
double v1 = 50.0;
22-
double v2 = 50.0;
23-
double expected = 0.0;
24-
double result = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2);
25-
assertEquals(
26-
expected, result, "Percentage difference should be zero when both values are equal.");
27-
}
21+
@Test
22+
void whenv1Andv2AreEqual_thenPercentageDifferenceIsZero() {
23+
double v1 = 50.0;
24+
double v2 = 50.0;
25+
double expected = 0.0;
26+
double result = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2);
27+
assertEquals(expected, result, "Percentage difference should be zero when both values are equal.");
28+
}
2829

29-
@Test
30-
void whenV1IsGreaterThanV2_thenCalculateCorrectPercentageDifference() {
31-
double v1 = 70.0;
32-
double v2 = 50.0;
33-
double expected = 33.33;
34-
double result = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2);
35-
assertEquals(expected, result, 0.01, "Percentage difference should be correctly calculated.");
36-
}
30+
@Test
31+
void whenv1IsGreaterThanv2_thenCalculateCorrectPercentageDifference() {
32+
double v1 = 70.0;
33+
double v2 = 50.0;
34+
double expected = 33.33;
35+
double result = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2);
36+
assertEquals(expected, result, 0.01, "Percentage difference should be correctly calculated.");
37+
}
3738

38-
@Test
39-
void whenV2IsGreaterThanV1_thenCalculateCorrectPercentageDifference() {
40-
double v1 = 50.0;
41-
double v2 = 70.0;
42-
double expected = 33.33;
43-
double result = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2);
44-
assertEquals(expected, result, 0.01, "Percentage difference should be correctly calculated.");
45-
}
39+
@Test
40+
void whenv2IsGreaterThanv1_thenCalculateCorrectPercentageDifference() {
41+
double v1 = 50.0;
42+
double v2 = 70.0;
43+
double expected = 33.33;
44+
double result = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2);
45+
assertEquals(expected, result, 0.01, "Percentage difference should be correctly calculated.");
46+
}
4647

47-
@Test
48-
void whenOneValueIsZero_thenCalculateCorrectPercentageDifference() {
49-
double v1 = 0.0;
50-
double v2 = 50.0;
51-
double expected = 200.0;
52-
double result = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2);
53-
assertEquals(
54-
expected,
55-
result,
56-
"Percentage difference should be correctly calculated when one value is zero.");
57-
}
48+
@Test
49+
void whenOneValueIsZero_thenCalculateCorrectPercentageDifference() {
50+
double v1 = 0.0;
51+
double v2 = 50.0;
52+
double expected = 200.0;
53+
double result = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2);
54+
assertEquals(expected, result, "Percentage difference should be correctly calculated when one value is zero.");
55+
}
5856

59-
@Test
60-
void whenAverageIsZero_thenThrowIllegalArgumentException() {
61-
double v1 = -50.0;
62-
double v2 = 50.0;
63-
assertThrows(
64-
IllegalArgumentException.class,
65-
() -> PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2),
66-
"Should throw IllegalArgumentException when the average of V1 and V2 is zero.");
67-
}
57+
@Test
58+
void whenAverageIsZero_thenThrowIllegalArgumentException() {
59+
double v1 = -50.0;
60+
double v2 = 50.0;
61+
assertThrows(IllegalArgumentException.class, () -> PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2),
62+
"Should throw IllegalArgumentException when the average of V1 and V2 is zero.");
63+
}
6864

69-
@Test
70-
void whenV1AndV2AreSwapped_thenPercentageDifferenceIsSame() {
71-
double v1 = 70.0;
72-
double v2 = 50.0;
73-
double expected = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2);
74-
double result = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v2, v1);
75-
assertEquals(
76-
expected,
77-
result,
78-
0.01,
79-
"Percentage difference should be the same when V1 and V2 are swapped.");
80-
}
65+
@Test
66+
void whenv1Andv2AreSwapped_thenPercentageDifferenceIsSame() {
67+
double v1 = 70.0;
68+
double v2 = 50.0;
69+
double expected = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v1, v2);
70+
double result = PercentDiffBetweenTwoNumbers.calculatePercentageDifference(v2, v1);
71+
assertEquals(expected, result, 0.01, "Percentage difference should be the same when v1 and v2 are swapped.");
72+
}
8173
}

0 commit comments

Comments
 (0)