Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hardcoded limit of number of models in embeddings query. #37

Open
SohamKukreti opened this issue Jul 4, 2024 · 0 comments
Open

Comments

@SohamKukreti
Copy link
Collaborator

in /dbt_llm_tools/vector_store.py
n_results has a default value set to 3.

def query_collection(
        self, query: str, n_results: int = 3
    ) -> list[ParsedSearchResult]:

also in /client/pages/chat.py
n_results is hardcoded to 4.

def get_matching_models(query):
    return vector_store.query_collection(query=query, n_results=4)

Ideally we should have the vector store return all the models where the cosine distance is above a certain threshold value.

@SohamKukreti SohamKukreti changed the title Replace hardcoded limit of number of models in embedings query. Replace hardcoded limit of number of models in embeddings query. Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant