✅ [SOLVED] VIM 9.0 - lsp-hover scrolling (+1, +3) (patch: 9baef1f1) - Popup does not scroll down completely.

[curedent]

Hi there,

I've experienced some problems with the lsp-hover on VIM 9.0 while scrolling completely down. Often, the scroll is stuck before the end, leaving some precious documentation unreadable. It becomes more apparent when the popup width is smaller.

I spotted the commit (9baef1f1) by @hrsh7th at the date of 22-12-03 changing the following
File: /vim-lsp/autoload/vital/_lsp/VS/Vim/Window.vim
Line: 109

- let l:topline = min([l:topline, line('$') - l:wininfo.height + 3])
+ let l:topline = min([l:topline, line('$') - l:wininfo.height + 1])

If I understand correctly,

topline = Number of line in the popup, minus the height of the popup, which contains +2 lines for the borders (top, bottom lines), +1 for rounding. So...

line('$') - (l:wininfo.height-2) + 1

The initial +3 fix my situation.

I am asking why this line has changed from +3 to +1 ? It might be for NeoVim?

Thank you!

My VIM version:
VIM - Vi IMproved 9.0 (2022 Jun 28, compiled May 04 2023 10:24:44)

[mattn]

Probably, the gap of 1 & 3 is width of border lines.

[prabirshrestha]

might be @hrsh7th can comment.

The original repo for the library can be found at https://github.com/hrsh7th/vim-vital-vs

[hrsh7th]

Hm... I forgotten the reason of this...

I guess I should add border_width to s:info and then calculate border-offset via this.

I'll check it later.

[hrsh7th]

@curedent Could you re-try with patching this diff?

https://github.com/hrsh7th/vim-vital-vs/pull/25/files#diff-efec83c7ca1a82f3135273b518ac444e327bb4cd95fdb0695cf9c35daa92cef4

[curedent]

@hrsh7th

I tested with VIM only and it is working well!

Thank you a lot!

[hrsh7th]

Sent a PR.
https://github.com/prabirshrestha/vim-lsp/pull/1556/files