Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the CI linting steps #72

Closed
wants to merge 1 commit into from
Closed

improve the CI linting steps #72

wants to merge 1 commit into from

Conversation

pythops
Copy link

@pythops pythops commented Aug 3, 2024

Catch more errors/warnings. The main branch has those warnings for example

error: field `content_type` is never read
  --> src/lsp/transport.rs:30:9
   |
28 | pub struct Header {
   |            ------ field in this struct
29 |     pub content_length: usize,
30 |     pub content_type: Option<String>,
   |         ^^^^^^^^^^^^
   |
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`

error: field `0` is never read
  --> src/socketwrapper.rs:17:8
   |
17 |     Ip(net::SocketAddr),
   |     -- ^^^^^^^^^^^^^^^
   |     |
   |     field in this variant
   |
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
17 |     Ip(()),
   |        ~~

error: field `0` is never read
  --> src/socketwrapper.rs:19:10
   |
19 |     Unix(tokio::net::unix::SocketAddr),
   |     ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |     |
   |     field in this variant
   |
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
19 |     Unix(()),
   |          ~~

error: could not compile `ra-multiplex` (lib) due to 3 previous errors
111

@pr2502
Copy link
Owner

pr2502 commented Aug 4, 2024

hi, thanks for pointing this out, this warning is new with rustc 1.79.0 (probably rust-lang/rust#118297) which is why i haven't noticed before as i'm still using 1.78 for development. i don't want the CI to stop working whenever rustc introduces new warnings so i won't be merging this

@pr2502 pr2502 closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants