Fix potential crash when adjusting offset #31644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
added
area:gameplay
next release
…djust is not allowed This should theoretically not be possible, but while we are sharing this control's implementation between gameplay and non-gameplay usages, let's ensure nothing weird can occur.
Hopefully don't need to overthink this one.
peppy
force-pushed
the
fix-beatmap-offset-crash
branch
from
cd0b11a to
8f8a645
Compare
bdach
requested changes
Jan 24, 2025
bdach
requested changes
Jan 24, 2025
peppy
force-pushed
the
fix-beatmap-offset-crash
branch
from
560b26f to
721b2df
Compare
bdach
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If offset is adjusted close to the cutoff point of being allowed, a realm callback might cause a crash when it really shouldn't.
Also guarded against one other potential failure scenario which probably can't happen (see commit message).
We could probably dump this in the hotfix release.
Closes #31642.