Fix not being able to apply last play offset after returning to song select #31386
+51
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lect" This reverts commit ced8dda.
I don't really like adding this new session static, but we don't have a better place to put this.
smoogipoo
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
I suppose this is okay, though it increases my concern about storing ScoreInfo to statics. It's hard for me to predict (at this stage) whether anything/everything will be leaked here and wreak havoc.
(We have already seen/discussed the existing static leaking a little bit, saved only by the presumption it's reset every play)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed with #30905, so I've gone about fixing the underlying issue in a different way.
Hopefully this is amicable.
Closes #31085.