Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to disable/toggle mods during replays #8357

Open
Joehuu opened this issue Mar 19, 2020 · 4 comments · May be fixed by #19925
Open

Ability to disable/toggle mods during replays #8357

Joehuu opened this issue Mar 19, 2020 · 4 comments · May be fixed by #19925
Labels
area:replay priority:3 Nice to have, at some point

Comments

@Joehuu
Copy link
Member

Joehuu commented Mar 19, 2020

Stable already does double time/half time and flashlight, but lazer can probably have more mods to disable during replays (i.e. hard rock, hidden, etc.).
@peppy peppy added the priority:3 Nice to have, at some point label Mar 21, 2020
@peppy
Copy link
Member

peppy commented Mar 21, 2020

Should be a relatively simple implementation, but will require reinitialisation of some elements of Player so needs to be treated with care.

@frenzibyte frenzibyte mentioned this issue Mar 2, 2021
Closed
@peppy peppy mentioned this issue Apr 1, 2021
Closed
@peppy peppy changed the title Ability to disable mods during replays Ability to disable/toggle mods during replays Apr 1, 2021
@cdwcgt
Copy link
Contributor

cdwcgt commented Aug 23, 2022 •
edited
Loading

branch

2022-08-23_09-17-39.mp4

this is design fine?

All that's left is replayLoaded detection and unit testing

I added an interface named IApplicableToDisable for which mod can be disabled in replay

@peppy
Copy link
Member

peppy commented Aug 23, 2022

It looks okay, but that interface name sounds weird.

How about ICanBeToggledDuringReplay or similar?

@cdwcgt
Copy link
Contributor

cdwcgt commented Aug 23, 2022

of course
I'll open a pr if I think its done

@cdwcgt cdwcgt linked a pull request Aug 23, 2022 that will close this issue
Draft
15 tasks
@Joehuu Joehuu mentioned this issue Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:replay priority:3 Nice to have, at some point
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to toggle mods during replay cdwcgt/osu
3 participants
@peppy @cdwcgt @Joehuu